You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 18:40:50 UTC
[GitHub] [beam] ibzib opened a new pull request #11123: [BEAM-9503] Insert
missing comma in process worker script.
ibzib opened a new pull request #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123
@amaliujia I'm not sure why this bug hasn't been caught before, but this whole code path is broken and it's going to block TFX-on-Flink, so I request a cherry-pick for this PR.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598887272
Run Python 3.6 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-599791417
Run Python 3.5 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-599638654
Python 3.5 and 3.7 postcommits flaked because of BEAM-8866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11123: [BEAM-9503] Insert
missing comma in process worker script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598864723
@ibzib do you know what is the relevant postcommit? Could we run those as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11123: [BEAM-9503] Insert
missing comma in process worker script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598864045
Run Python2 Postcommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598887235
Run Python 2 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598867396
> @ibzib do you know what is the relevant postcommit? Could we run those as well?
This bug has been around for a while, so apparently this code branch is not being tested. We will have to follow up and investigate why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598887299
Run Python 3.7 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11123: [BEAM-9503] Insert
missing comma in process worker script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598864412
Run Python3 Postcommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11123: [BEAM-9503] Insert
missing comma in process worker script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598864536
Run Python Postcommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib merged pull request #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib merged pull request #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11123: [BEAM-9503] Insert
missing comma in process worker script.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598871213
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-598887261
Run Python 3.5 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] ibzib commented on issue #11123: [BEAM-9503] Insert missing
comma in process worker script.
Posted by GitBox <gi...@apache.org>.
ibzib commented on issue #11123: [BEAM-9503] Insert missing comma in process worker script.
URL: https://github.com/apache/beam/pull/11123#issuecomment-599791452
Run Python 3.7 PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services