You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Timur Alperovich <no...@github.com> on 2015/06/26 02:06:30 UTC

[jclouds] JCLOUDS-931: Sleep only after creating containers. (#789)

jclouds should issue the requests to create all of the containers in
the container pool before sleeping. The patch modifies the
awaitConsistency method to be cognizant of whether the container pool
has been initialized or not. If the pool has not been initialized, the
method returns immediately and does not sleep.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/789

-- Commit Summary --

  * JCLOUDS-931: Sleep only after creating containers.

-- File Changes --

    M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobStoreIntegrationTest.java (10)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/789.patch
https://github.com/jclouds/jclouds/pull/789.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/789

Re: [jclouds] JCLOUDS-931: Sleep only after creating containers. (#789)

Posted by Andrew Gaul <no...@github.com>.
Pushed to master as e63474a8242aabab38785567d53467dd825d956f and 1.9.x as a05f369807a75c16f68837fbe00d03b7dbdcb934.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/789#issuecomment-115886510

Re: [jclouds] JCLOUDS-931: Sleep only after creating containers. (#789)

Posted by Timur Alperovich <no...@github.com>.
> @@ -531,6 +532,9 @@ protected Module createHttpModule() {
>     }
>  
>     protected void awaitConsistency() {
> +      if (!initialized) {

Done

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/789/files#r33394864

Re: [jclouds] JCLOUDS-931: Sleep only after creating containers. (#789)

Posted by Andrew Gaul <no...@github.com>.
Closed #789.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/789#event-341647647

Re: [jclouds] JCLOUDS-931: Sleep only after creating containers. (#789)

Posted by Andrew Gaul <no...@github.com>.
> @@ -531,6 +532,9 @@ protected Module createHttpModule() {
>     }
>  
>     protected void awaitConsistency() {
> +      if (!initialized) {

This seems magical.  Instead should we pass a flag to `createContainerAndEnsureEmpty` which controls the call to `awaitConsistency`?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/789/files#r33330972