Re: [jira] [Commented] (UIMA-4212) Add methods to CasUtil to select and index intersecting annotations

[José Tomás Atria <jt...@gmail.com>]

Sorry for not getting back to you about this before. I've been very busy
trying to finish my doctoral dissertation :)

In brief: no, I'm afraid I don't have any tests. I was totally new to any
sort of serious programming when I wrote those methods, so I had no idea
what unit tests were.

I'm a little swamped right now between teaching and research, but as soon
as I have a moment to spare, I'll look into it and incorporate your
suggestions (and whip up some tests).

Thanks for considering the patch!


On Wed, Dec 23, 2015 at 7:40 PM, Richard Eckart de Castilho (JIRA) <
dev@uima.apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/UIMA-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070349#comment-15070349
> ]
>
> Richard Eckart de Castilho commented on UIMA-4212:
> --------------------------------------------------
>
> I've had a look at the patch (finally!)
>
> * You don't have any unit tests for the new method by any chance, do you?
> * I am pretty sure the type subsumption test in the offsets-based
> selectIntersects is not needed
> * given that the annotation index is sorted, it should be possible to stop
> iteration early in the offsets-based method like in the
> reference-annotation-based method
> * I'd tend to rename the methods to "selectIntersecting" (cf.
> "selectCovering")
>
>
> > Add methods to CasUtil to select and index intersecting annotations
> > -------------------------------------------------------------------
> >
> >                 Key: UIMA-4212
> >                 URL: https://issues.apache.org/jira/browse/UIMA-4212
> >             Project: UIMA
> >          Issue Type: Improvement
> >          Components: uimaFIT
> >            Reporter: Jose Tomas Atria
> >            Assignee: Richard Eckart de Castilho
> >            Priority: Minor
> >              Labels: newbie, patch
> >             Fix For: 2.2.0uimaFIT
> >
> >         Attachments: selectIntersects.patch
> >
> >
> > CasUtil includes methods to select and index covered and covering
> annotations of a given type (ie, supersets and subsets of an annotation's
> interval).
> > The attached patch adds methods to select and index intersecting
> annotations,  either including covering annotations or not.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>



-- 
entia non sunt multiplicanda praeter necessitatem