You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/11 02:36:37 UTC

[GitHub] [spark] itholic commented on a diff in pull request #39492: [SPARK-41876][CONNECT][PYTHON] Connect can not test with `test_dataframe` due to `AnalysisException` coverted to `SparkConnectAnalysisException`

itholic commented on code in PR #39492:
URL: https://github.com/apache/spark/pull/39492#discussion_r1066521015


##########
python/pyspark/sql/tests/connect/test_parity_dataframe.py:
##########
@@ -120,8 +120,7 @@ def test_same_semantics_error(self):
     def test_sample(self):
         super().test_sample()
 
-    # TODO(SPARK-41875): throw proper errors in Dataset.to()

Review Comment:
   So, it sounds like now we throws proper errors, but the test still disabled ??
   
   If so, maybe we should say like:
   ```python
   # TODO(SPARK-XXXXX): Implement Dataset `to`
   @unittest.skip("Fails in Spark Connect, should enable.")
   ```
   
   ??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org