You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Fox (JIRA)" <ji...@apache.org> on 2012/04/24 15:05:34 UTC
[jira] [Created] (TORQUE-195) Remove autocommit handling from
Transaction management
Thomas Fox created TORQUE-195:
---------------------------------
Summary: Remove autocommit handling from Transaction management
Key: TORQUE-195
URL: https://issues.apache.org/jira/browse/TORQUE-195
Project: Torque
Issue Type: Improvement
Components: Runtime
Affects Versions: 3.3.1, 3.3
Reporter: Thomas Fox
Currently, transaction handling is very unclean.
- Transaction.beginOptional sets autocommit to false on a connection under certain conditions, but Transaction.commit() does not know what autocommit was beforehand and sets it to true under certain conditions, regardless of the connection state before
- The field Criteria.useTransaction can be used to disable the autocommit switching when starting a transaction (but not the switching back)
Autocommit should be handled by the connection pool, not by the OR Mapper, and should be removed from the Torque code. This would lead to the following modifications
- remove the Transaction.beginOptional method
- remove the useTransaction field from Criteria
If an explicit transaction handling is desired, this can still be done by doing the connection/transaction handling in application code and using the methods which take a transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Closed] (TORQUE-195) Remove autocommit handling from
Transaction management
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox closed TORQUE-195.
-----------------------------
> Remove autocommit handling from Transaction management
> ------------------------------------------------------
>
> Key: TORQUE-195
> URL: https://issues.apache.org/jira/browse/TORQUE-195
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Affects Versions: 3.3, 3.3.1
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0-beta1
>
>
> Currently, transaction handling is very unclean.
> - Transaction.beginOptional sets autocommit to false on a connection under certain conditions, but Transaction.commit() does not know what autocommit was beforehand and sets it to true under certain conditions, regardless of the connection state before
> - The field Criteria.useTransaction can be used to disable the autocommit switching when starting a transaction (but not the switching back)
> Autocommit should be handled by the connection pool, not by the OR Mapper, and should be removed from the Torque code. This would lead to the following modifications
> - remove the Transaction.beginOptional method
> - remove the useTransaction field from Criteria
> If an explicit transaction handling is desired, this can still be done by doing the connection/transaction handling in application code and using the methods which take a transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
[jira] [Resolved] (TORQUE-195) Remove autocommit handling from
Transaction management
Posted by "Thomas Fox (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TORQUE-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Fox resolved TORQUE-195.
-------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Thomas Fox
> Remove autocommit handling from Transaction management
> ------------------------------------------------------
>
> Key: TORQUE-195
> URL: https://issues.apache.org/jira/browse/TORQUE-195
> Project: Torque
> Issue Type: Improvement
> Components: Runtime
> Affects Versions: 3.3, 3.3.1
> Reporter: Thomas Fox
> Assignee: Thomas Fox
> Fix For: 4.0
>
>
> Currently, transaction handling is very unclean.
> - Transaction.beginOptional sets autocommit to false on a connection under certain conditions, but Transaction.commit() does not know what autocommit was beforehand and sets it to true under certain conditions, regardless of the connection state before
> - The field Criteria.useTransaction can be used to disable the autocommit switching when starting a transaction (but not the switching back)
> Autocommit should be handled by the connection pool, not by the OR Mapper, and should be removed from the Torque code. This would lead to the following modifications
> - remove the Transaction.beginOptional method
> - remove the useTransaction field from Criteria
> If an explicit transaction handling is desired, this can still be done by doing the connection/transaction handling in application code and using the methods which take a transaction.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org