You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/31 10:03:25 UTC
[GitHub] [rocketmq] Git-Yang opened a new pull request #3690: [ISSUE #3680] Optimize instance construct
Git-Yang opened a new pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690
**Make sure set the target branch to `develop`**
## What is the purpose of the change
https://github.com/apache/rocketmq/issues/3680
## Brief changelog
- Add clientIndex to ensure that the instances between processes do not conflict and solve the problem of clientId conflicts in the container. (Remove the time stamp method, which is not conducive to instance reuse)
- Add groupIndex to solve the problem of creating instance conflicts with the same subscription group in the process.
- Add namesrvIndex to solve the problem of creating instance conflicts with different namesrv addresses in the process.
- Add unit test.
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3690: [ISSUE #3680] Optimize instance manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690#issuecomment-1007275513
[](https://coveralls.io/builds/45466514)
Coverage increased (+0.06%) to 53.196% when pulling **110d7abe23f9ea77c2182acc2bb754e8629fe8ed on Git-Yang:dev-instance** into **d564dcd31a7e5740693e5faef8863ea9fd739a9c on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3690: [ISSUE #3680] Optimize instance manager
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690#issuecomment-1007275513
[](https://coveralls.io/builds/45446622)
Coverage decreased (-0.04%) to 53.229% when pulling **cf6ae77e053b984980c072468bea4ac0362353c6 on Git-Yang:dev-instance** into **ed5f4e4eac71849bc479aee2db7cc931d262a184 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3690: [ISSUE #3680] Optimize instance manager
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690#issuecomment-1007275513
[](https://coveralls.io/builds/45446622)
Coverage decreased (-0.04%) to 53.229% when pulling **cf6ae77e053b984980c072468bea4ac0362353c6 on Git-Yang:dev-instance** into **ed5f4e4eac71849bc479aee2db7cc931d262a184 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3690: [ISSUE #3680] Optimize instance manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690#issuecomment-1007275513
[](https://coveralls.io/builds/45466514)
Coverage increased (+0.06%) to 53.196% when pulling **110d7abe23f9ea77c2182acc2bb754e8629fe8ed on Git-Yang:dev-instance** into **d564dcd31a7e5740693e5faef8863ea9fd739a9c on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3690: [ISSUE #3680] Optimize instance manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690#issuecomment-1007275513
[](https://coveralls.io/builds/45485760)
Coverage increased (+0.1%) to 53.212% when pulling **e76a59a80699033d0dd2ab29c4b29e6132d7eac9 on Git-Yang:dev-instance** into **acac49f148b5c1070471d72a10b881cc15c58d6b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3690: [ISSUE #3680] Optimize instance manager
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3690:
URL: https://github.com/apache/rocketmq/pull/3690#issuecomment-1007275513
[](https://coveralls.io/builds/45490480)
Coverage increased (+0.1%) to 53.23% when pulling **41c56b11f1de29c391f667d0417bdf4be6663b64 on Git-Yang:dev-instance** into **acac49f148b5c1070471d72a10b881cc15c58d6b on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org