[GitHub] [pinot] gortiz commented on a diff in pull request #8736: Remove abuse of new ObjectMapper.

[GitBox <gi...@apache.org>]

gortiz commented on code in PR #8736:
URL: https://github.com/apache/pinot/pull/8736#discussion_r879071151


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##########
@@ -90,6 +90,11 @@ public static <T> T stringToObject(String jsonString, Class<T> valueType)
     return DEFAULT_READER.forType(valueType).readValue(jsonString);
   }
 
+  public static <T> T readValue(String jsonString, Class<T> valueType)

Review Comment:
   I created these new methods where it made sense to conserve the original jackson methods names. It makes clearer that the semantic didn't change in the PR and it seems easier to understand for someone that knows jackson.
   
   But I can remove the duplication if we think that it isn't useful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org