You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/28 15:27:51 UTC

[GitHub] [flink] leozhangsr opened a new pull request, #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

leozhangsr opened a new pull request, #20389:
URL: https://github.com/apache/flink/pull/20389

   ## What is the purpose of the change
   Stopping offset can be 0.When we make a zero stopping offset empty,it would be serialized to NO_STOPPING_OFFSET, which it is not expected.
   It' had been fixed in master by https://github.com/apache/flink/pull/20234, now need to merge into release-1.15.
   
   ## Brief change log
   change a stopping offset conditon from '>0' to '>=0'
   
   ## Verifying this change
   Can be verified by:
   KafkaPartitionSplitReaderTest#testAssignEmptySplit
   KafkaPartitionSplitSerializerTest
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr closed pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by "leozhangsr (via GitHub)" <gi...@apache.org>.
leozhangsr closed pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0
URL: https://github.com/apache/flink/pull/20389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20389:
URL: https://github.com/apache/flink/pull/20389#issuecomment-1207122536

   @PatrickRen Do you have time to handle this rq? and the requests for release-1.14 ,https://github.com/apache/flink/pull/20387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20389:
URL: https://github.com/apache/flink/pull/20389#issuecomment-1227969108

   > Commit message looks in sync with master
   As in pull request(https://github.com/apache/flink/pull/20234), PatrickRen asked for another two pull request for release-1.14 and release-1.15, so I made this two pull request(https://github.com/apache/flink/pull/20389,https://github.com/apache/flink/pull/20387), hoping they can be merged.
   I will be glad to get a reply.
   ![image](https://user-images.githubusercontent.com/20127034/186799720-d337b001-f277-4efe-87f9-50cb3fc06ad6.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by GitBox <gi...@apache.org>.
leozhangsr commented on PR #20389:
URL: https://github.com/apache/flink/pull/20389#issuecomment-1200064744

   > @leozhangsr Looks like the commit message is not consistent with the one on master branch and not quite descriptive. Could you update the commit message? You can just copy & paste from master.
   
   Thanks for suggestion.Commit message updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] leozhangsr commented on pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by "leozhangsr (via GitHub)" <gi...@apache.org>.
leozhangsr commented on PR #20389:
URL: https://github.com/apache/flink/pull/20389#issuecomment-1680079846

   already close


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] PatrickRen commented on pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by GitBox <gi...@apache.org>.
PatrickRen commented on PR #20389:
URL: https://github.com/apache/flink/pull/20389#issuecomment-1198965305

   @leozhangsr Looks like the commit message is not consistent with the one on master branch and not quite descriptive. Could you update the commit message? You can just copy & paste from master. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20389: [FLINK-28475] [Connector/kafka] stopping offset can be 0

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20389:
URL: https://github.com/apache/flink/pull/20389#issuecomment-1198318985

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "74ff89b4a02e4ca7c9a7996f643f4afae20e0428",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "74ff89b4a02e4ca7c9a7996f643f4afae20e0428",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74ff89b4a02e4ca7c9a7996f643f4afae20e0428 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org