You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/10/16 23:44:19 UTC
Re: Review Request 62143: Added validation for Standalone Container
APIs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62143/
-----------------------------------------------------------
(Updated Oct. 16, 2017, 4:44 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Summary (updated)
-----------------
Added validation for Standalone Container APIs.
Bugs: MESOS-7492
https://issues.apache.org/jira/browse/MESOS-7492
Repository: mesos
Description
-------
The Standalone Container APIs act much like the nested container APIs,
except that ContainerIDs do not necessarily need to have a parent.
Additionally, the 'resources' field in the `LAUNCH_CONTAINER` API
has some restrictions due to how these resources are not reported
to the master.
Diffs (updated)
-----
src/slave/validation.cpp a575d88dffd2714447d7780a7433506a6e8c085f
Diff: https://reviews.apache.org/r/62143/diff/2/
Changes: https://reviews.apache.org/r/62143/diff/1-2/
Testing
-------
See later in chain.
Thanks,
Joseph Wu
Re: Review Request 62143: Added validation for Standalone Container
APIs.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62143/#review190396
-----------------------------------------------------------
src/slave/validation.cpp
Lines 381 (patched)
<https://reviews.apache.org/r/62143/#comment267728>
You may want to normalize the resources to `POST_RESERVATION_REFINEMENT` format and use `isUnreserved` check below?
src/slave/validation.cpp
Lines 396-400 (patched)
<https://reviews.apache.org/r/62143/#comment267729>
This can be `isUnreserved` if the resources are normalized to post refinement format.
src/slave/validation.cpp
Lines 407-408 (patched)
<https://reviews.apache.org/r/62143/#comment267730>
You can use `Resources::isPersistentVolume`
- Jie Yu
On Oct. 16, 2017, 11:44 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62143/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 11:44 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Standalone Container APIs act much like the nested container APIs,
> except that ContainerIDs do not necessarily need to have a parent.
>
> Additionally, the 'resources' field in the `LAUNCH_CONTAINER` API
> has some restrictions due to how these resources are not reported
> to the master.
>
>
> Diffs
> -----
>
> src/slave/validation.cpp a575d88dffd2714447d7780a7433506a6e8c085f
>
>
> Diff: https://reviews.apache.org/r/62143/diff/3/
>
>
> Testing
> -------
>
> See later in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 62143: Added validation for Standalone Container
APIs.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62143/#review190982
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 14, 2017, 1:27 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62143/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2017, 1:27 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7305
> https://issues.apache.org/jira/browse/MESOS-7305
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Standalone Container APIs act much like the nested container APIs,
> except that ContainerIDs do not necessarily need to have a parent.
>
> Additionally, the 'resources' field in the `LAUNCH_CONTAINER` API
> has some restrictions due to how these resources are not reported
> to the master.
>
>
> Diffs
> -----
>
> src/slave/validation.cpp a575d88dffd2714447d7780a7433506a6e8c085f
>
>
> Diff: https://reviews.apache.org/r/62143/diff/4/
>
>
> Testing
> -------
>
> See later in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 62143: Added validation for Standalone Container
APIs.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62143/
-----------------------------------------------------------
(Updated Nov. 13, 2017, 5:27 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Changed some of the resource validation to use the common helpers. Functionality should remain the same.
Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305
Repository: mesos
Description
-------
The Standalone Container APIs act much like the nested container APIs,
except that ContainerIDs do not necessarily need to have a parent.
Additionally, the 'resources' field in the `LAUNCH_CONTAINER` API
has some restrictions due to how these resources are not reported
to the master.
Diffs (updated)
-----
src/slave/validation.cpp a575d88dffd2714447d7780a7433506a6e8c085f
Diff: https://reviews.apache.org/r/62143/diff/4/
Changes: https://reviews.apache.org/r/62143/diff/3-4/
Testing
-------
See later in chain.
Thanks,
Joseph Wu