RE: svn commit: r1710215 - in /subversion/trunk/subversion:bindings/javahl/native/SVNClient.cpp include/svn_client.hlibsvn_client/cleanup.c

[be...@qqmail.nl]

While many libsvn client functions still take every path as argument, most new functions (and many revved functions) now only take absolute paths. I don’t think that we should reverse this step by changing the behavior further.

Changing the documentation in a backport may break future usages of the api for those who develop against new 1.9 versions and then link against an older version.

See some recent backport nominations of Julian that didn’t even want to just canonicalize input from environment variables, where we didn’t canonicalize before.


Slowly moving towards canonicalized required (which we documented before 1.0 as required) and absolute paths for working copy paths (since 1.7 on most if not all new apis) are small steps to making the api easier to depend on. (We can’t guarantee stable notifications on relative paths; especially when using multiple targets at the same time)


I’d rather see a backport of the fix in javahl as recommended in the original mail posts, while keeping the api working as promised. 

Unnecessary abspath conversions everywhere as we had in early 1.7 development are performance killers. It is better to convert as early as possible at the library boundary.

     Bert

Sent from Mail for Windows 10



From: philip@apache.org
Sent: vrijdag 23 oktober 2015 15:56
To: commits@subversion.apache.org
Subject: svn commit: r1710215 - in /subversion/trunk/subversion:bindings/javahl/native/SVNClient.cpp include/svn_client.hlibsvn_client/cleanup.c


Author: philip
Date: Fri Oct 23 13:56:40 2015
New Revision: 1710215

URL: http://svn.apache.org/viewvc?rev=1710215&view=rev
Log:
Allow svn_client_vacuum and svn_client_cleanup2 to accept non-absolute
paths and convert to absolute, rather than asserting that the passed
paths are absolute.  This makes the functions behave like other client
functions.

Re: svn commit: r1710215 - in /subversion/trunk/subversion:bindings/javahl/native/SVNClient.cpp include/svn_client.hlibsvn_client/cleanup.c

[Philip Martin <ph...@wandisco.com>]

<be...@qqmail.nl> writes:

> While many libsvn client functions still take every path as argument,
> most new functions (and many revved functions) now only take absolute
> paths. I don’t think that we should reverse this step by changing the
> behavior further.

OK, I've reverted the libsvn_client part, leaving the JNI part. See
r1710290.

-- 
Philip Martin
WANdisco