You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/25 08:12:57 UTC
[GitHub] [nuttx-apps] xiaoxiang781216 opened a new pull request, #1502: netutils/cjson: Enable cjson test
xiaoxiang781216 opened a new pull request, #1502:
URL: https://github.com/apache/nuttx-apps/pull/1502
## Summary
## Impact
New test case, but disabled by default
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1502: netutils/cjson: Enable cjson test
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #1502:
URL: https://github.com/apache/nuttx-apps/pull/1502#discussion_r1087208653
##########
netutils/cjson/Kconfig:
##########
@@ -20,4 +20,16 @@ config NETUTILS_CJSON_VERSION
string "Version number"
default "1.7.12"
+config NETUTILS_CJSON_TEST
+ bool "enable cjson test"
Review Comment:
```suggestion
bool "Enable cJSON test"
```
##########
netutils/cjson/Kconfig:
##########
@@ -20,4 +20,16 @@ config NETUTILS_CJSON_VERSION
string "Version number"
default "1.7.12"
+config NETUTILS_CJSON_TEST
+ bool "enable cjson test"
+ default n
+
+if NETUTILS_CJSON_TEST
+
+config CJSON_UNITY_TEST_DIR
+ string "cjson test dir"
Review Comment:
```suggestion
string "cJSON test directory"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1502: netutils/cjson: Enable cjson test
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1502:
URL: https://github.com/apache/nuttx-apps/pull/1502#discussion_r1087382333
##########
netutils/cjson/Kconfig:
##########
@@ -20,4 +20,16 @@ config NETUTILS_CJSON_VERSION
string "Version number"
default "1.7.12"
+config NETUTILS_CJSON_TEST
+ bool "enable cjson test"
Review Comment:
Done.
##########
netutils/cjson/Kconfig:
##########
@@ -20,4 +20,16 @@ config NETUTILS_CJSON_VERSION
string "Version number"
default "1.7.12"
+config NETUTILS_CJSON_TEST
+ bool "enable cjson test"
+ default n
+
+if NETUTILS_CJSON_TEST
+
+config CJSON_UNITY_TEST_DIR
+ string "cjson test dir"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] pkarashchenko merged pull request #1502: netutils/cjson: Enable cjson test
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #1502:
URL: https://github.com/apache/nuttx-apps/pull/1502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org