You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2024/06/26 23:45:26 UTC
(shardingsphere) branch master updated: Reduce Cognitive Complexity on DorisStatementVisitor (#31877)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 7d0e129beeb Reduce Cognitive Complexity on DorisStatementVisitor (#31877)
7d0e129beeb is described below
commit 7d0e129beebe50579f3be6d528b74db5e7c40413
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Thu Jun 27 07:45:21 2024 +0800
Reduce Cognitive Complexity on DorisStatementVisitor (#31877)
---
.../visitor/statement/DorisStatementVisitor.java | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java b/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
index 7710fadd59a..1a937955263 100644
--- a/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
+++ b/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/DorisStatementVisitor.java
@@ -599,13 +599,13 @@ public abstract class DorisStatementVisitor extends DorisStatementBaseVisitor<AS
int startIndex = ctx.start.getStartIndex();
int stopIndex = ctx.stop.getStopIndex();
if (null != ctx.subquery()) {
- SubquerySegment subquerySegment = new SubquerySegment(ctx.subquery().getStart().getStartIndex(), ctx.subquery().getStop().getStopIndex(), (DorisSelectStatement) visit(ctx.subquery()),
- getOriginalText(ctx.subquery()));
- if (null != ctx.EXISTS()) {
- subquerySegment.setSubqueryType(SubqueryType.EXISTS_SUBQUERY);
- return new ExistsSubqueryExpression(startIndex, stopIndex, subquerySegment);
+ SubquerySegment subquerySegment = new SubquerySegment(
+ ctx.subquery().getStart().getStartIndex(), ctx.subquery().getStop().getStopIndex(), (DorisSelectStatement) visit(ctx.subquery()), getOriginalText(ctx.subquery()));
+ if (null == ctx.EXISTS()) {
+ return new SubqueryExpressionSegment(subquerySegment);
}
- return new SubqueryExpressionSegment(subquerySegment);
+ subquerySegment.setSubqueryType(SubqueryType.EXISTS_SUBQUERY);
+ return new ExistsSubqueryExpression(startIndex, stopIndex, subquerySegment);
}
if (null != ctx.parameterMarker()) {
ParameterMarkerValue parameterMarker = (ParameterMarkerValue) visit(ctx.parameterMarker());
@@ -623,11 +623,8 @@ public abstract class DorisStatementVisitor extends DorisStatementBaseVisitor<AS
return visit(ctx.functionCall());
}
if (null != ctx.collateClause()) {
- if (null != ctx.simpleExpr()) {
- ExpressionSegment expr = (ExpressionSegment) visit(ctx.simpleExpr(0));
- return new CollateExpression(startIndex, stopIndex, (SimpleExpressionSegment) visit(ctx.collateClause()), expr);
- }
- return new CollateExpression(startIndex, stopIndex, (SimpleExpressionSegment) visit(ctx.collateClause()), null);
+ ExpressionSegment expr = null == ctx.simpleExpr() ? null : (ExpressionSegment) visit(ctx.simpleExpr(0));
+ return new CollateExpression(startIndex, stopIndex, (SimpleExpressionSegment) visit(ctx.collateClause()), expr);
}
if (null != ctx.columnRef()) {
return visit(ctx.columnRef());