[GitHub] [iceberg] flyrain commented on a change in pull request #3557: Spark: Support vectorized reads with equality deletes

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #3557:
URL: https://github.com/apache/iceberg/pull/3557#discussion_r751708908



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/ColumnarBatchReader.java
##########
@@ -137,4 +165,30 @@ public final ColumnarBatch read(ColumnarBatch reuse, int numRowsToRead) {
       return Pair.of(rowIdMapping, currentRowId);
     }
   }
+
+  /**
+   * Reuse the row Id mapping array to filter out equality deleted rows.
+   */
+  private void applyEqDelete(ColumnarBatch batch, int[] posDeleteRowIdMapping, int[] eqDeleteRowIdMapping) {
+    int[] rowIdMapping = posDeleteRowIdMapping == null ? eqDeleteRowIdMapping : posDeleteRowIdMapping;

Review comment:
       Correct. I will move it outside of the method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org