PR2144 - no_detach [Re: time for 1.3.3]

[Janos Farkas <Ja...@lists.eon.ml.org>]

On 1998-09-29 at 07:40:44, Ken Coar wrote:
> detach() does more than just fork and reopen the files; it's also where
> the process group is set.  So I suspect your patch might need a
> little more to it -- but I haven't investigated in detail.

Aha, thanks, it seems I left my mind on vacation since a few months..  I
somehow believed the process group setting is used to cause the detach,
and not backwards.  I've put up a modified patch at

  http://eon.ml.org/dist/diffs/apache-1.3.x-nodetach-2.diff.gz

and sent a similar note to apbugs to update the PR.  It now modifies
detach to take an additional argument to decide whether to fork() or
not, all the rest will be done like before.  It's still simple, and it
still doesn't effect how apache works when the -n option is not
specified.  (Formerly, I thought skipping reopening std files is a
feature, just like not setting the process group, but the playing with
process handling in the latter way is certainly not a wise idea..
gack..)

Also, sorry, I don't want to persist with this minor issue, so feel free
to ignore if something is still wrong :)

-- 
Janos - Don't worry, my address is real.  I'm just bored of spam.