You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/28 14:29:29 UTC
[GitHub] [camel] JiriOndrusek opened a new pull request #3781: fix of test for CAMEL-14950
JiriOndrusek opened a new pull request #3781:
URL: https://github.com/apache/camel/pull/3781
Issue: https://issues.apache.org/jira/browse/CAMEL-14950
@davsclaus , @oscerd
I've noticed small error with big impact. Test for scenario with servlet was testing scenario without servlet. This simple change it fixes, but there is a problem.
By previous commit version of servlet-api was set to 3.1.0.Final to be consistent with camel - correct move. *But undertow is not able to start servlet without 4.0 api.*
So with this fix, test will show an error *NoClassDefFoundError: javax/servlet/http/MappingMatch*
(error will be solved in case of servlet-api org.jboss.spec.javax.servlet:jboss-servlet-api_4.0_spec)
Which seems to be blocker for this change. What do you think?
Only solution I see is to keep servlet-api required for undertow in pom.
[ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] JiriOndrusek commented on pull request #3781: fix of test for CAMEL-14950
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #3781:
URL: https://github.com/apache/camel/pull/3781#issuecomment-620661023
@davsclaus @oscerd
I can imagine a way of allowing this change by following restrictions:
- document requirement for higher servlet-api for usage of property `requireServletContext` (default value is false)
- dependency to higher-servlet-api would be only in component camel-undertow-spring-security (https://issues.apache.org/jira/browse/CAMEL-14977)
- tests involving servlet context could be placed into camel-undertow-spring-security
This solution is not correct, but I don't see any other possibility....
I can try to use some kind of mock servletContext which will allow to run security filters from spring-security without having servlet involved on undertrow server, but I have no idea whether it would be possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org