You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/07/11 16:24:32 UTC

[GitHub] [hudi] vinothchandar commented on a change in pull request #1650: [HUDI-541]: replaced dataFile/df with baseFile/bf throughout code base

vinothchandar commented on a change in pull request #1650:
URL: https://github.com/apache/hudi/pull/1650#discussion_r453210594



##########
File path: hudi-common/src/main/avro/HoodieCompactionOperation.avsc
##########
@@ -41,7 +41,7 @@
                      "default": null
                   },
                   {
-                     "name":"dataFilePath",
+                     "name":"baseFilePath",

Review comment:
       @pratyakshsharma @bvaradar is there a test here that checks for backwards compatibility?  i.e we should be very sure that existing plans should be readable with new schema.. (or may be also new plans by old schema?) 
   
   This is my main concern. Otherwise, renaming is not worth the hassle. :) for this particular case.. thoughts? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org