You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/23 16:22:08 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3512: NO-JIRA Save double property lookup on common case
franz1981 opened a new pull request #3512:
URL: https://github.com/apache/activemq-artemis/pull/3512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3512: NO-JIRA Save double property lookup on common case
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3512:
URL: https://github.com/apache/activemq-artemis/pull/3512#issuecomment-914057236
Leaving this as a draft until a proper JIRA is created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #3512: NO-JIRA Save double property lookup on common case
Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3512:
URL: https://github.com/apache/activemq-artemis/pull/3512#issuecomment-921301919
@franz1981, is the only thing holding this back the lack of a Jira? If so, I can create one, update the commit message, and merge this. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3512: NO-JIRA Save double property lookup on common case
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3512:
URL: https://github.com/apache/activemq-artemis/pull/3512#issuecomment-805806906
Looks good, but I think you need a JIRA on this one... you even wrote a test.. it doesn't seem a NO-JIRA to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] franz1981 commented on pull request #3512: NO-JIRA Save double property lookup on common case
Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3512:
URL: https://github.com/apache/activemq-artemis/pull/3512#issuecomment-921528551
@jbertram
> is the only thing holding this back the lack of a Jira..
Nope, I still need to rebase and run the whole test suite on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3512: NO-JIRA Save double property lookup on common case
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3512:
URL: https://github.com/apache/activemq-artemis/pull/3512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org