[GitHub] [sling-org-apache-sling-jcr-contentloader] stefanseifert commented on a change in pull request #9: SLING-10992 emit WARN in case of unknown attributes or directives in

[GitBox <gi...@apache.org>]

stefanseifert commented on a change in pull request #9:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/9#discussion_r767854969



##########
File path: src/main/java/org/apache/sling/jcr/contentloader/PathEntry.java
##########
@@ -100,6 +108,24 @@
      */
     public static final String IGNORE_CONTENT_READERS_DIRECTIVE = "ignoreImportProviders";
 
+    /** Used in https://github.com/apache/sling-maven-plugin/blob/d67d5c1900782c68c1bfcbdc499c02cf31224916/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/fsresource/SlingInitialContentMounter.java#L97 */
+    private static final String MAVEN_MOUNT_DIRECTIVE = "maven:mount";
+
+    /** All directive names which are valid for header Sling-Initial-Content */
+    public Set<String> VALID_DIRECTIVES = new HashSet<>(Arrays.asList(
+        OVERWRITE_DIRECTIVE,
+        OVERWRITE_PROPERTIES_DIRECTIVE,
+        MERGE_PROPERTIES_DIRECTIVE,
+        MERGE_NODES_DIRECTIVE,
+        UNINSTALL_DIRECTIVE,
+        PATH_DIRECTIVE,
+        WORKSPACE_DIRECTIVE,
+        CHECKIN_DIRECTIVE,
+        AUTOCHECKOUT_DIRECTIVE,
+        IGNORE_CONTENT_READERS_DIRECTIVE,
+        MAVEN_MOUNT_DIRECTIVE

Review comment:
       i do not understand why "maven:mount" is a directive. "mount" is a goal in sling-maven-plugin, what has it to do with the directives for the content loader?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org