[GitHub] [incubator-superset] hughhhh commented on a change in pull request #12230: chore: Removing datasets.ts file from codebase

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #12230:
URL: https://github.com/apache/incubator-superset/pull/12230#discussion_r551594647



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -40,6 +46,29 @@ import { exploreChart } from '../../explore/exploreUtils';
 import { CtasEnum } from '../actions/sqlLab';
 import { Query } from '../types';
 
+const updateDatset = async (
+  datasetId: number,
+  dbId: number,
+  sql: string,
+  columns: Array<Record<string, any>>,
+  overrideColumns: boolean,
+) => {
+  const endpoint = `api/v1/dataset/${datasetId}?override_columns=${overrideColumns}`;
+  const headers = { 'Content-Type': 'application/json' };

Review comment:
       Yea i get 400 back without setting the `Content-Type` for the header




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org