You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2016/03/01 00:11:02 UTC
[Impala-CR](cdh5-trunk) IMPALA-2738 Hive/Impala inconsistency in GRANT syntax
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT syntax
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/2296/2//COMMIT_MSG
Commit Message:
Line 7: GRANT syntax
> Don't we need to support REVOKE as well?
Done
http://gerrit.cloudera.org:8080/#/c/2296/2/fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java
File fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java:
Line 173: if (serverName_ == null) {
: serverName_ = analyzer.getAuthzConfig().getServerName();
: }
> In the commit msg you mention that if server name is specified, it is check
Sorry, forgot to update the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/2296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: Yes