[GitHub] [incubator-nuttx] MTres19 commented on pull request #5151: WIP: Tiva CAN driver

[GitBox <gi...@apache.org>]

MTres19 commented on pull request #5151:
URL: https://github.com/apache/incubator-nuttx/pull/5151#issuecomment-1008236696


   Thanks, I wanted to post it for review even though there's a couple of things still in progress. I'll squash and clean up for nxstyle when I have a chance.
   
   For the bit-timing, SYSCLK_FREQUENCY actually is already used to calculate the baud rate prescaler. But it's still bad because TSEG1, TSEG2, and SJW are fixed and may not be correct when the division doesn't come out even. Ideally the application would never work with something as low-level as that because the optimal configuration depends on the clock frequency. I wrote a function (not specifically for NuttX, but I could try to see if I still have it) to determine the optimal configuration based on crystal tolerances between the different ECUs on the bus and the maximum values for TSEG1 and TSEG2 and SJW. It would be nice so implement something like that in the upper-half driver and just hook into the lower-half driver to get the available settings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org