You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/03/18 22:20:26 UTC
[GitHub] [openwhisk-client-go] advancedwebdeveloper opened a new issue #150: Benchmarking the reflection API
advancedwebdeveloper opened a new issue #150:
URL: https://github.com/apache/openwhisk-client-go/issues/150
I have modified the source files as follows:
> diff --git a/go.mod b/go.mod
> index 0491f2d..eb9c282 100644
> --- a/go.mod
> +++ b/go.mod
> @@ -1,12 +1,13 @@
> module github.com/apache/openwhisk-client-go
>
> -go 1.15
> +go 1.16
>
> require (
> github.com/BurntSushi/toml v0.3.1 // indirect
> github.com/cloudfoundry/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
> github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
> github.com/fatih/color v1.10.0
> + github.com/goccy/go-reflect v1.1.0
> github.com/google/go-querystring v1.0.0
> github.com/hokaccha/go-prettyjson v0.0.0-20210113012101-fb4e108d2519
> github.com/nicksnyder/go-i18n v1.10.1
> diff --git a/go.sum b/go.sum
> index 25fcb1b..86cd625 100644
> --- a/go.sum
> +++ b/go.sum
> @@ -11,6 +11,8 @@ github.com/fatih/color v1.10.0/go.mod h1:ELkj/draVOlAH/xkhN6mQ50Qd0MPOk5AAr3maGE
> github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo=
> github.com/fsnotify/fsnotify v1.4.9 h1:hsms1Qyu0jgnwNXIxa+/V/PDsU6CfLf6CNO8H7IWoS4=
> github.com/fsnotify/fsnotify v1.4.9/go.mod h1:znqG4EE+3YCdAaPaxE2ZRY/06pZUdp0tY4IgpuI1SZQ=
> +github.com/goccy/go-reflect v1.1.0 h1:kiT3+exv9ULtdpawlMzCGT1y5bWOmuY3jgS86GB9t1s=
> +github.com/goccy/go-reflect v1.1.0/go.mod h1:n0oYZn8VcV2CkWTxi8B9QjkCoq6GTtCEdfmR66YhFtE=
> github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
> github.com/golang/protobuf v1.4.0-rc.1/go.mod h1:ceaxUfeHdC40wWswd/P6IGgMaK3YpKi5j83Wpe3EHw8=
> github.com/golang/protobuf v1.4.0-rc.1.0.20200221234624-67d41d38c208/go.mod h1:xKAWHe0F5eneWXFV3EuXVDTCmh+JuBKY0li0aMyXATA=
> diff --git a/whisk/client.go b/whisk/client.go
> index 0bd25cd..5f18a8f 100644
> --- a/whisk/client.go
> +++ b/whisk/client.go
> @@ -29,12 +29,13 @@ import (
> "net"
> "net/http"
> "net/url"
> - "reflect"
> "regexp"
> "runtime"
> "strings"
> "time"
>
> + reflect "github.com/goccy/go-reflect"
> +
> "github.com/apache/openwhisk-client-go/wski18n"
> )
>
> diff --git a/whisk/util.go b/whisk/util.go
> index 683c680..32e7a09 100644
> --- a/whisk/util.go
> +++ b/whisk/util.go
> @@ -21,9 +21,10 @@ import (
> "errors"
> "fmt"
> "net/url"
> - "reflect"
> "strings"
>
> + reflect "github.com/goccy/go-reflect"
> +
> "github.com/apache/openwhisk-client-go/wski18n"
> "github.com/fatih/color"
> "github.com/google/go-querystring/query"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-client-go] advancedwebdeveloper commented on issue #150: Benchmarking the reflection API
Posted by GitBox <gi...@apache.org>.
advancedwebdeveloper commented on issue #150:
URL: https://github.com/apache/openwhisk-client-go/issues/150#issuecomment-802349617
Looks like the project is compiling and tests are running.
I was suggesting to benchmark these API calls:
https://github.com/apache/openwhisk-client-go/blob/49c58e00354d315ce82766c785c69193df0514e8/whisk/util.go#L61
https://github.com/apache/openwhisk-client-go/blob/49c58e00354d315ce82766c785c69193df0514e8/whisk/util.go#L62
https://github.com/apache/openwhisk-client-go/blob/cfe1b517ce627f5c18b175044e20a7a36e3b1e08/whisk/client.go#L704
https://github.com/apache/openwhisk-client-go/blob/cfe1b517ce627f5c18b175044e20a7a36e3b1e08/whisk/client.go#L713
https://github.com/apache/openwhisk-client-go/blob/cfe1b517ce627f5c18b175044e20a7a36e3b1e08/whisk/client.go#L716
https://github.com/apache/openwhisk-client-go/blob/cfe1b517ce627f5c18b175044e20a7a36e3b1e08/whisk/client.go#L433
I saw thinking about a test suite, containing a test-function-per-callee.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org