[GitHub] markusthoemmes commented on a change in pull request #3416: Unit test PoolingRestClient

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3416: Unit test PoolingRestClient
URL: https://github.com/apache/incubator-openwhisk/pull/3416#discussion_r173771805
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/http/PoolingRestClient.scala
 ##########
 @@ -42,7 +44,13 @@ import spray.json._
  *  on each request because it doesn't need to look up the pool corresponding
  *  to the host. It is also easier to add an extra queueing mechanism.
  */
-class PoolingRestClient(protocol: String, host: String, port: Int, queueSize: Int)(implicit system: ActorSystem) {
+class PoolingRestClient(
+  protocol: String,
+  host: String,
+  port: Int,
+  queueSize: Int,
+  httpFlow: Option[Flow[(HttpRequest, Promise[HttpResponse]), (Try[HttpResponse], Promise[HttpResponse]), Any]] = None)(
 
 Review comment:
   Have you thought about overriding `requestQueue` instead of passing in an arbitrary flow here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services