You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/26 04:56:57 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3258: Apply `filters` and `limits` when building logical plan in `ViewTable::scan`

Dandandan commented on code in PR #3258:
URL: https://github.com/apache/arrow-datafusion/pull/3258#discussion_r955649455


##########
datafusion/core/src/datasource/view.rs:
##########
@@ -342,6 +355,43 @@ mod tests {
         Ok(())
     }
 
+    #[tokio::test]
+    async fn query_view_with_filter_and_limit() -> Result<()> {
+        let session_ctx = SessionContext::with_config(
+            SessionConfig::new().with_information_schema(true),
+        );
+
+        session_ctx
+            .sql("CREATE TABLE abc AS VALUES (1,2,3), (4,5,6), (7,8,9)")

Review Comment:
   Could you test the plan as well (with `EXPLAIN`)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org