You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/04 14:28:21 UTC

[GitHub] [flink] tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface

tillrohrmann commented on a change in pull request #8362: [FLINK-11391] Introduce shuffle master interface
URL: https://github.com/apache/flink/pull/8362#discussion_r290275962
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputGateDeploymentDescriptor.java
 ##########
 @@ -54,23 +58,30 @@
 	 * The index of the consumed subpartition of each consumed partition. This index depends on the
 	 * {@link DistributionPattern} and the subtask indices of the producing and consuming task.
 	 */
+	@Nonnegative
 	private final int consumedSubpartitionIndex;
 
 	/** An input channel for each consumed subpartition. */
-	private final InputChannelDeploymentDescriptor[] inputChannels;
+	private final ShuffleDescriptor[] inputChannels;
+
+	/**
+	 * {@link ResourceID} of partition consume to identify its location.
 
 Review comment:
   typo: `consume` -> `consumer`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services