You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2014/05/02 03:49:15 UTC
Review Request 21004: Updated stout to satisfy whitespace/indent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21004/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Updated stout to satisfy whitespace/indent.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp aca97ca
Diff: https://reviews.apache.org/r/21004/diff/
Testing
-------
make check
With whitespace/line_length enabled, $ ./support/mesos-style.py
Checking 424 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/tab,+whitespace/todo
Total errors found: 0
Whitespace-only changes don't show up in RB, so you can download the diff yourself, or see the contents below:
--- a/3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
+++ b/3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
@@ -88,6 +88,6 @@ TEST(LinkedHashmapTest, Values)
int val = 0;
foreach (int value, map.values()) {
- ASSERT_EQ(++val, value);
+ ASSERT_EQ(++val, value);
}
}
Thanks,
Adam B
Re: Review Request 21004: Updated stout to satisfy whitespace/indent.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21004/#review42087
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On May 2, 2014, 1:49 a.m., Adam B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21004/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 1:49 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated stout to satisfy whitespace/indent.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp aca97ca
>
> Diff: https://reviews.apache.org/r/21004/diff/
>
>
> Testing
> -------
>
> make check
> With whitespace/line_length enabled, $ ./support/mesos-style.py
> Checking 424 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+runtime/vlog,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/tab,+whitespace/todo
> Total errors found: 0
>
> Whitespace-only changes don't show up in RB, so you can download the diff yourself, or see the contents below:
> --- a/3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
> +++ b/3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
> @@ -88,6 +88,6 @@ TEST(LinkedHashmapTest, Values)
>
> int val = 0;
> foreach (int value, map.values()) {
> - ASSERT_EQ(++val, value);
> + ASSERT_EQ(++val, value);
> }
> }
>
>
> Thanks,
>
> Adam B
>
>