You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "Yangsx-1 (via GitHub)" <gi...@apache.org> on 2023/06/17 06:41:40 UTC
[GitHub] [incubator-kvrocks] Yangsx-1 opened a new issue, #1503: Convert the timeout parameter from an integer to a double value
Yangsx-1 opened a new issue, #1503:
URL: https://github.com/apache/incubator-kvrocks/issues/1503
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
In redis, the timeout parameter of commands like [BLPOP](https://redis.io/commands/blpop/) is a double value, but in kvrocks, the parameter must be an integer.
### Solution
We can change `parseint` in the Parse function into `parsefloat`.
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kvrocks] git-hulk closed issue #1503: Convert the timeout parameter from an integer to a double value
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #1503: Convert the timeout parameter from an integer to a double value
URL: https://github.com/apache/kvrocks/issues/1503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #1503: Convert the timeout parameter from an integer to a double value
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1503:
URL: https://github.com/apache/incubator-kvrocks/issues/1503#issuecomment-1595717878
> > Hi @Yangsx-1
> > Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218
>
>  But i tested it locally, timeout can be floating-point number?
oh, good. You're right that Redis will parse it as a double when the unit is a second:https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/timeout.c#L171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #1503: Convert the timeout parameter from an integer to a double value
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1503:
URL: https://github.com/apache/incubator-kvrocks/issues/1503#issuecomment-1595711938
Hi @Yangsx-1
Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #1503: Convert the timeout parameter from an integer to a double value
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1503:
URL: https://github.com/apache/incubator-kvrocks/issues/1503#issuecomment-1595718365
@Yangsx-1 assigned, thanks for your good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Yangsx-1 commented on issue #1503: Convert the timeout parameter from an integer to a double value
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on issue #1503:
URL: https://github.com/apache/incubator-kvrocks/issues/1503#issuecomment-1595716690
> Hi @Yangsx-1
>
> Many thanks for your feedback. It should be a mistake in the Redis document, the timeout in the BLPOP is an integer indeed: https://github.com/redis/redis/blob/b00a2351865bb1d87e2d2701b77c8a68daefb054/src/t_list.c#L1218
But i tested it locally, timeout can be floating-point number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org