You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/06 22:03:25 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28177: Migrate remaining core sensors tests to `pytest`
Taragolis opened a new pull request, #28177:
URL: https://github.com/apache/airflow/pull/28177
Follow-up with migration remaining unittests TestCases in core to pytest
Include just sensors because found long running test in it which actually could run less than second
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28177:
URL: https://github.com/apache/airflow/pull/28177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on code in PR #28177:
URL: https://github.com/apache/airflow/pull/28177#discussion_r1041507344
##########
tests/sensors/test_external_task_sensor.py:
##########
@@ -166,8 +165,9 @@ def test_external_task_group_not_exists_without_check_existence(self):
task_id="test_external_task_sensor_check",
external_dag_id=TEST_DAG_ID,
external_task_group_id="fake-task-group",
- timeout=1,
+ timeout=0.001,
dag=self.dag,
+ poke_interval=0.1,
Review Comment:
Default `poke_interval` is 60 second as result test wait 1 minute for timeout exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28177:
URL: https://github.com/apache/airflow/pull/28177#issuecomment-1341150990
I must have merged it by mistake, not seeing the failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #28177:
URL: https://github.com/apache/airflow/pull/28177#issuecomment-1341229313
@Taragolis https://github.com/apache/airflow/pull/28193#issuecomment-1341179598 these two tests together (prior to the revert) fail `tests/task/task_runner/test_task_runner.py::TestGetTaskRunner::test_should_support_core_task_runner tests/sensors/test_external_task_sensor.py::TestExternalTaskSensor::test_external_task_sensor_failed_states_as_success`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28177:
URL: https://github.com/apache/airflow/pull/28177#issuecomment-1340098808
really strange error in test. I assume that some other test could change in logging and do not teardown correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28177:
URL: https://github.com/apache/airflow/pull/28177#issuecomment-1341153332
https://github.com/apache/airflow/pull/28196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on pull request #28177: Migrate remaining core sensors tests to `pytest`
Posted by GitBox <gi...@apache.org>.
Taragolis commented on PR #28177:
URL: https://github.com/apache/airflow/pull/28177#issuecomment-1341081403
@potiuk @uranusjr I think some test in `other` overwrites some logging and not properly revert it back.
I would tried to figure out which one. Because if run locally in breeze only this module nothing bad happen.
As workaround we could just revert this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org