[jira] [Commented] (PIG-3786) POReservoirSample should handle endOfAllInput flag

["Cheolsoo Park (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921404#comment-13921404 ] 

Cheolsoo Park commented on PIG-3786:
------------------------------------

+1. I will commit this shortly. 

> POReservoirSample should handle endOfAllInput flag
> --------------------------------------------------
>
>                 Key: PIG-3786
>                 URL: https://issues.apache.org/jira/browse/PIG-3786
>             Project: Pig
>          Issue Type: Sub-task
>          Components: tez
>    Affects Versions: tez-branch
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: tez-branch
>
>         Attachments: PIG-3786-1.patch
>
>
> POReservoirSample assumes it always get STATUS_OK until it hits STATUS_EOP, means all inputs finished. This is not true if the plan also contains a POStream, since POStream will issue a STATUS_EOP even if inputs are not exhausted. Need to make POReservoirSample handles STATUS_EOP and endOfAllInput flag. This cause e2e test failure such as ComputeSpec_3.
> POPoissonSample should do the same.



--
This message was sent by Atlassian JIRA
(v6.2#6252)