You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/05/14 17:45:51 UTC
[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #80: cmd/img_mgmt/port/zephyr: fix to img_mgmt_impl_erase_image_data()
de-nordic opened a new pull request #80:
URL: https://github.com/apache/mynewt-mcumgr/pull/80
It was possible that the function tried to eras non erase-block-size
aligned number of bytes witch might have cause failure.
Additionally the image trailer area might have been not erased at all.
Reworked implementation so:
- the erase request is corrected to erase proper amount of memory
- erase of image trailer is ensured.
Signed-off-by: Andrzej Puzdrowski <an...@nordicsemi.no>
PR initiated per request from @nvlsianpu (https://github.com/zephyrproject-rtos/mcumgr/pull/22)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] nvlsianpu commented on pull request #80: cmd/img_mgmt/port/zephyr: fix to img_mgmt_impl_erase_image_data()
Posted by GitBox <gi...@apache.org>.
nvlsianpu commented on pull request #80:
URL: https://github.com/apache/mynewt-mcumgr/pull/80#issuecomment-629166161
Tested via Zephyr-RTOS CI - green. Can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] nvlsianpu commented on pull request #80: cmd/img_mgmt/port/zephyr: fix to img_mgmt_impl_erase_image_data()
Posted by GitBox <gi...@apache.org>.
nvlsianpu commented on pull request #80:
URL: https://github.com/apache/mynewt-mcumgr/pull/80#issuecomment-629098190
Added also content off https://github.com/zephyrproject-rtos/mcumgr/pull/21 so this PR synchronize repositories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] utzig merged pull request #80: cmd/img_mgmt/port/zephyr: fix to img_mgmt_impl_erase_image_data()
Posted by GitBox <gi...@apache.org>.
utzig merged pull request #80:
URL: https://github.com/apache/mynewt-mcumgr/pull/80
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] ccollins476ad commented on pull request #80: cmd/img_mgmt/port/zephyr: fix to img_mgmt_impl_erase_image_data()
Posted by GitBox <gi...@apache.org>.
ccollins476ad commented on pull request #80:
URL: https://github.com/apache/mynewt-mcumgr/pull/80#issuecomment-628934729
I don't think I'm familiar enough with zephyr to give a useful review. It looks reasonable to me for what that's worth :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #80: cmd/img_mgmt/port/zephyr: fix to img_mgmt_impl_erase_image_data()
Posted by GitBox <gi...@apache.org>.
de-nordic commented on pull request #80:
URL: https://github.com/apache/mynewt-mcumgr/pull/80#issuecomment-628789090
@ccollins476ad, @mlaz please review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org