[GitHub] [superset] betodealmeida commented on a diff in pull request #24547: feat: customize screenshot width for alerts/reports

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #24547:
URL: https://github.com/apache/superset/pull/24547#discussion_r1246840069


##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -853,12 +864,16 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
     }).then(response => setChartVizType(response.json.result.viz_type));
 
   // Handle input/textarea updates
-  const onTextChange = (
+  const onInputChange = (
     event: React.ChangeEvent<HTMLTextAreaElement | HTMLInputElement>,
   ) => {
     const { target } = event;
+    const value =
+      target.type === 'number'

Review Comment:
   No, it's just the `<input type="XXX" />` value.



##########
superset-frontend/src/components/ReportModal/index.tsx:
##########
@@ -257,6 +263,29 @@ function ReportModal({
       </div>
     </>
   );
+  const renderCustomWidthSection = (
+    <StyledInputContainer>
+      <div
+        className="control-label"
+        css={(theme: SupersetTheme) => CustomWidthHeaderStyle(theme)}

Review Comment:
   D'oh, will fix. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org