You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/10 09:00:16 UTC
[GitHub] [doris] luozenglin opened a new pull request, #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
luozenglin opened a new pull request, #14986:
URL: https://github.com/apache/doris/pull/14986
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #14986:
URL: https://github.com/apache/doris/pull/14986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14986:
URL: https://github.com/apache/doris/pull/14986#issuecomment-1345254524
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.45 seconds
load time: 462 seconds
storage size: 17123356802 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221210122845_clickbench_pr_61358.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14986:
URL: https://github.com/apache/doris/pull/14986#issuecomment-1345758278
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14986:
URL: https://github.com/apache/doris/pull/14986#issuecomment-1345273071
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #14986:
URL: https://github.com/apache/doris/pull/14986#discussion_r1045392795
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -300,7 +300,9 @@ Status PipelineFragmentContext::_build_pipelines(ExecNode* node, PipelinePtr cur
auto node_type = node->type();
switch (node_type) {
// for source
- case TPlanNodeType::OLAP_SCAN_NODE: {
Review Comment:
seems mysql scan node can be same here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14986:
URL: https://github.com/apache/doris/pull/14986#issuecomment-1345213543
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14986:
URL: https://github.com/apache/doris/pull/14986#issuecomment-1345758291
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14986:
URL: https://github.com/apache/doris/pull/14986#issuecomment-1345190697
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #14986: [enhancement](pipeline) support jdbc scan, jdbc sink, odbc scan and odbc sink node for pipeline.
Posted by GitBox <gi...@apache.org>.
luozenglin commented on code in PR #14986:
URL: https://github.com/apache/doris/pull/14986#discussion_r1045396993
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -300,7 +300,9 @@ Status PipelineFragmentContext::_build_pipelines(ExecNode* node, PipelinePtr cur
auto node_type = node->type();
switch (node_type) {
// for source
- case TPlanNodeType::OLAP_SCAN_NODE: {
Review Comment:
The current `VMysqlScanNode` inherits from `ScanNode`, and later can unify support for `NewMysqlScanNode` inherits from `VScanNode`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org