You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/30 04:01:21 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new pull request, #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
SbloodyS opened a new pull request, #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
close #10566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#discussion_r912310975
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -28,3 +28,71 @@ click the button on the right of the [language](#language) button and then click
you want to switch. All time related components will adjust their time zone according to the time zone setting you select.
+## Standalone Switching Metadata Database Configuration
+
+We here use MySQL as an example to illustrate how to configure an external database:
Review Comment:
I think under the directory `HOWTO` and same level with `general-setting.md` is a great place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#discussion_r910943273
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -28,3 +28,71 @@ click the button on the right of the [language](#language) button and then click
you want to switch. All time related components will adjust their time zone according to the time zone setting you select.
+## Standalone Switching Metadata Database Configuration
+
+We here use MySQL as an example to illustrate how to configure an external database:
Review Comment:
Can we create an new file to keep those content? I will migrate how to use other database in "datasource center" in the ferther, currently they are in https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/guide/datasource/introduction.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#discussion_r911789440
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -28,3 +28,71 @@ click the button on the right of the [language](#language) button and then click
you want to switch. All time related components will adjust their time zone according to the time zone setting you select.
+## Standalone Switching Metadata Database Configuration
+
+We here use MySQL as an example to illustrate how to configure an external database:
Review Comment:
Which path should we put into this new file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#issuecomment-1173393001
> I have two suggestion.
>
> * we should add new page to siderbar, https://github.com/apache/dolphinscheduler/blob/dev/docs/configs/docsdev.js. But we already `how to` to FAQ sub sidebar. So I am not sure where is the best place to keep it. maybe we should add it next to https://github.com/apache/dolphinscheduler/blob/dev/docs/configs/docsdev.js#L383
> * I think we should combine existing datasource setting from https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/datasource/introduction.md#using-datasource-incompatible-to-apache-license-v2-license to `how-to/datasource-setting.md`
That's good. I'll add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#issuecomment-1173261166
> ## Purpose of the pull request
> close #10566
Great, and thank for you bring this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#discussion_r912580924
##########
docs/docs/en/guide/howto/general-setting.md:
##########
@@ -28,3 +28,71 @@ click the button on the right of the [language](#language) button and then click
you want to switch. All time related components will adjust their time zone according to the time zone setting you select.
+## Standalone Switching Metadata Database Configuration
+
+We here use MySQL as an example to illustrate how to configure an external database:
Review Comment:
Done. PTAL @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#issuecomment-1173503106
Still have deadlink on your patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#issuecomment-1173503579
> Still have deadlink on your patch
I'm fixing it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10688: [Feature-10566][Doc] unified data source switching of the docs during installation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10688:
URL: https://github.com/apache/dolphinscheduler/pull/10688#issuecomment-1173490460
FYI, one deadlink found https://github.com/apache/dolphinscheduler/runs/7176457415?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org