You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/09 16:33:33 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11982: feat: confirm overwrite when importing
betodealmeida opened a new pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR changes the import API to require an explicit flag in order to overwrite existing assets.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Added unit tests, both for the commands and the API.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (4ac8cdd) into [consolidate_import_logic](https://codecov.io/gh/apache/incubator-superset/commit/2297f9bef25081ed3e35c659eef3de15cc2fd8ca?el=desc) (2297f9b) will **decrease** coverage by `3.96%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## consolidate_import_logic #11982 +/- ##
============================================================
- Coverage 67.67% 63.70% -3.97%
============================================================
Files 939 939
Lines 45408 45416 +8
Branches 4361 4361
============================================================
- Hits 30728 28932 -1796
- Misses 14577 16307 +1730
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.94% <ø> (ø)` | |
| python | `64.15% <97.56%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [2297f9b...4ac8cdd](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.22%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 63.82% +0.22%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18250 -10734
+ Misses 16415 10344 -6071
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.82% <97.56%> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.50% <100.00%> (-1.57%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [487 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.42%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
- Coverage 63.59% 63.17% -0.43%
==========================================
Files 940 467 -473
Lines 45575 28579 -16996
Branches 4373 0 -4373
==========================================
- Hits 28984 18054 -10930
+ Misses 16415 10525 -5890
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.17% <97.56%> (-0.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.87% <100.00%> (-5.20%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (8100b55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.01%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 63.61% +0.01%
==========================================
Files 940 940
Lines 45575 45982 +407
Branches 4373 4500 +127
==========================================
+ Hits 28984 29251 +267
- Misses 16415 16553 +138
- Partials 176 178 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.03% <ø> (+0.29%)` | :arrow_up: |
| python | `63.96% <97.56%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <100.00%> (-0.89%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...8100b55](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (8100b55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.24%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
- Coverage 63.59% 63.34% -0.25%
==========================================
Files 940 940
Lines 45575 45982 +407
Branches 4373 4500 +127
==========================================
+ Hits 28984 29129 +145
- Misses 16415 16675 +260
- Partials 176 178 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.03% <ø> (+0.29%)` | :arrow_up: |
| python | `63.53% <97.56%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <100.00%> (-0.89%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...8100b55](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (8100b55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.11%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 63.71% +0.11%
==========================================
Files 940 940
Lines 45575 45982 +407
Branches 4373 4500 +127
==========================================
+ Hits 28984 29297 +313
- Misses 16415 16507 +92
- Partials 176 178 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.03% <ø> (+0.29%)` | :arrow_up: |
| python | `64.12% <97.56%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <100.00%> (-0.89%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...8100b55](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.07%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
- Coverage 63.59% 63.52% -0.08%
==========================================
Files 940 940
Lines 45575 45593 +18
Branches 4373 4373
==========================================
- Hits 28984 28963 -21
- Misses 16415 16454 +39
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <ø> (ø)` | |
| python | `63.99% <97.56%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.50% <100.00%> (-1.57%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (8100b55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.01%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 63.61% +0.01%
==========================================
Files 940 940
Lines 45575 45982 +407
Branches 4373 4500 +127
==========================================
+ Hits 28984 29250 +266
- Misses 16415 16554 +139
- Partials 176 178 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `63.03% <ø> (+0.29%)` | :arrow_up: |
| python | `63.95% <97.56%> (-0.15%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <100.00%> (-0.89%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...8100b55](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (c7b9a02) into [consolidate_import_logic](https://codecov.io/gh/apache/incubator-superset/commit/2297f9bef25081ed3e35c659eef3de15cc2fd8ca?el=desc) (2297f9b) will **decrease** coverage by `4.44%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## consolidate_import_logic #11982 +/- ##
============================================================
- Coverage 67.67% 63.22% -4.45%
============================================================
Files 939 466 -473
Lines 45408 28481 -16927
Branches 4361 0 -4361
============================================================
- Hits 30728 18008 -12720
+ Misses 14577 10473 -4104
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.22% <97.56%> (-0.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.87% <100.00%> (-5.20%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [503 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [2297f9b...4ac8cdd](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.39%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 63.99% +0.39%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18298 -10686
+ Misses 16415 10296 -6119
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.99% <97.56%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.50% <100.00%> (-1.57%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [482 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (4ac8cdd) into [consolidate_import_logic](https://codecov.io/gh/apache/incubator-superset/commit/2297f9bef25081ed3e35c659eef3de15cc2fd8ca?el=desc) (2297f9b) will **decrease** coverage by `3.96%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## consolidate_import_logic #11982 +/- ##
============================================================
- Coverage 67.67% 63.70% -3.97%
============================================================
Files 939 939
Lines 45408 45416 +8
Branches 4361 4361
============================================================
- Hits 30728 28932 -1796
- Misses 14577 16307 +1730
- Partials 103 177 +74
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.94% <ø> (ø)` | |
| python | `64.15% <97.56%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [2297f9b...4ac8cdd](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (4ac8cdd) into [consolidate_import_logic](https://codecov.io/gh/apache/incubator-superset/commit/2297f9bef25081ed3e35c659eef3de15cc2fd8ca?el=desc) (2297f9b) will **decrease** coverage by `3.98%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## consolidate_import_logic #11982 +/- ##
============================================================
- Coverage 67.67% 63.68% -3.99%
============================================================
Files 939 466 -473
Lines 45408 28496 -16912
Branches 4361 0 -4361
============================================================
- Hits 30728 18147 -12581
+ Misses 14577 10349 -4228
+ Partials 103 0 -103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <97.56%> (-0.49%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.69% <100.00%> (-2.38%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [2297f9b...4ac8cdd](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (4ac8cdd) into [consolidate_import_logic](https://codecov.io/gh/apache/incubator-superset/commit/2297f9bef25081ed3e35c659eef3de15cc2fd8ca?el=desc) (2297f9b) will **decrease** coverage by `0.12%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## consolidate_import_logic #11982 +/- ##
============================================================
- Coverage 67.67% 67.54% -0.13%
============================================================
Files 939 939
Lines 45408 45426 +18
Branches 4361 4361
============================================================
- Hits 30728 30682 -46
- Misses 14577 14637 +60
- Partials 103 107 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.33% <ø> (-0.55%)` | :arrow_down: |
| javascript | `62.94% <ø> (ø)` | |
| python | `64.15% <97.56%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [13 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [2297f9b...4ac8cdd](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (4ac8cdd) into [consolidate_import_logic](https://codecov.io/gh/apache/incubator-superset/commit/2297f9bef25081ed3e35c659eef3de15cc2fd8ca?el=desc) (2297f9b) will **decrease** coverage by `0.00%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## consolidate_import_logic #11982 +/- ##
============================================================
- Coverage 67.67% 67.66% -0.01%
============================================================
Files 939 939
Lines 45408 45426 +18
Branches 4361 4361
============================================================
+ Hits 30728 30738 +10
- Misses 14577 14585 +8
Partials 103 103
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.91% <ø> (+0.03%)` | :arrow_up: |
| javascript | `62.94% <ø> (ø)` | |
| python | `64.15% <97.56%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [2297f9b...4ac8cdd](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.00%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
- Coverage 63.59% 63.58% -0.01%
==========================================
Files 940 940
Lines 45575 45593 +18
Branches 4373 4373
==========================================
+ Hits 28984 28992 +8
- Misses 16415 16425 +10
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <ø> (ø)` | |
| python | `64.09% <97.56%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (8100b55) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **decrease** coverage by `0.35%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
- Coverage 63.59% 63.23% -0.36%
==========================================
Files 940 940
Lines 45575 45593 +18
Branches 4373 4373
==========================================
- Hits 28984 28832 -152
- Misses 16415 16585 +170
Partials 176 176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `62.73% <ø> (ø)` | |
| python | `63.53% <97.56%> (-0.58%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.24% <100.00%> (-0.89%)` | :arrow_down: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...8100b55](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `0.23%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 63.82% +0.23%
==========================================
Files 940 467 -473
Lines 45575 28594 -16981
Branches 4373 0 -4373
==========================================
- Hits 28984 18251 -10733
+ Misses 16415 10343 -6072
+ Partials 176 0 -176
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `?` | |
| python | `63.82% <97.56%> (-0.28%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.50% <100.00%> (-1.57%)` | :arrow_down: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [486 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11982: feat: confirm overwrite when importing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11982:
URL: https://github.com/apache/incubator-superset/pull/11982#issuecomment-741979432
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=h1) Report
> Merging [#11982](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=desc) (60b15bb) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9256b6fb3dcd58cc0956d07c0e947a4f87fbe737?el=desc) (9256b6f) will **increase** coverage by `3.94%`.
> The diff coverage is `97.56%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11982 +/- ##
==========================================
+ Coverage 63.59% 67.54% +3.94%
==========================================
Files 940 940
Lines 45575 45603 +28
Branches 4373 4373
==========================================
+ Hits 28984 30802 +1818
+ Misses 16415 14696 -1719
+ Partials 176 105 -71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.70% <ø> (?)` | |
| javascript | `62.73% <ø> (ø)` | |
| python | `64.09% <97.56%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <95.23%> (+0.63%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.60% <100.00%> (+0.06%)` | :arrow_up: |
| [superset/charts/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `86.52% <100.00%> (+0.05%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.11% <100.00%> (+0.04%)` | :arrow_up: |
| [...perset/databases/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2ltcG9ydGVycy92MS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.16% <100.00%> (+0.03%)` | :arrow_up: |
| [...uperset/datasets/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [179 more](https://codecov.io/gh/apache/incubator-superset/pull/11982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=footer). Last update [9256b6f...60b15bb](https://codecov.io/gh/apache/incubator-superset/pull/11982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org