You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2012/05/07 13:10:05 UTC
svn commit: r1334953 - /subversion/trunk/subversion/svnserve/main.c
Author: stsp
Date: Mon May 7 11:10:05 2012
New Revision: 1334953
URL: http://svn.apache.org/viewvc?rev=1334953&view=rev
Log:
* subversion/svnserve/main.c: In 'svnserve --help' document the default
IP address and port number used by svnserve.
Modified:
subversion/trunk/subversion/svnserve/main.c
Modified: subversion/trunk/subversion/svnserve/main.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnserve/main.c?rev=1334953&r1=1334952&r2=1334953&view=diff
==============================================================================
--- subversion/trunk/subversion/svnserve/main.c (original)
+++ subversion/trunk/subversion/svnserve/main.c Mon May 7 11:10:05 2012
@@ -150,6 +150,11 @@ void winservice_notify_stop(void)
#define SVNSERVE_OPT_CACHE_REVPROPS 267
#define SVNSERVE_OPT_SINGLE_CONN 268
+/* Helper macros to stringify ra_svn's default port number. */
+#define SVNSERVE_PORT(p) SVNSERVE_PORT_STR(p)
+#define SVNSERVE_PORT_STR(p) #p
+
+
static const apr_getopt_option_t svnserve__options[] =
{
{"daemon", 'd', 0, N_("daemon mode")},
@@ -167,11 +172,11 @@ static const apr_getopt_option_t svnserv
N_("read configuration from file ARG")},
{"listen-port", SVNSERVE_OPT_LISTEN_PORT, 1,
#ifdef WIN32
- N_("listen port\n"
+ N_("listen port. The default port is " SVNSERVE_PORT(SVN_RA_SVN_PORT) "\n"
" "
"[mode: daemon, service, listen-once]")},
#else
- N_("listen port\n"
+ N_("listen port. The default port is " SVNSERVE_PORT(SVN_RA_SVN_PORT) ".\n"
" "
"[mode: daemon, listen-once]")},
#endif
@@ -179,10 +184,14 @@ static const apr_getopt_option_t svnserv
#ifdef WIN32
N_("listen hostname or IP address\n"
" "
+ "By default svnserve listens on all addresses.\n"
+ " "
"[mode: daemon, service, listen-once]")},
#else
N_("listen hostname or IP address\n"
" "
+ "By default svnserve listens on all addresses.\n"
+ " "
"[mode: daemon, listen-once]")},
#endif
{"prefer-ipv6", '6', 0,
Re: svn commit: r1334953 -
/subversion/trunk/subversion/svnserve/main.c
Posted by Stefan Sperling <st...@elego.de>.
On Mon, May 07, 2012 at 09:30:30AM -0400, Greg Stein wrote:
> On May 7, 2012 7:10 AM, <st...@apache.org> wrote:
> >...
> > +++ subversion/trunk/subversion/svnserve/main.c Mon May 7 11:10:05 2012
> > @@ -150,6 +150,11 @@ void winservice_notify_stop(void)
> > #define SVNSERVE_OPT_CACHE_REVPROPS 267
> > #define SVNSERVE_OPT_SINGLE_CONN 268
> >
> > +/* Helper macros to stringify ra_svn's default port number. */
> > +#define SVNSERVE_PORT(p) SVNSERVE_PORT_STR(p)
> > +#define SVNSERVE_PORT_STR(p) #p
>
> I'd suggest APR_STRINGIFY rather than new macros.
Oh! Neat. r1335021, thanks.
Re: svn commit: r1334953 - /subversion/trunk/subversion/svnserve/main.c
Posted by Greg Stein <gs...@gmail.com>.
On May 7, 2012 7:10 AM, <st...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/svnserve/main.c Mon May 7 11:10:05 2012
> @@ -150,6 +150,11 @@ void winservice_notify_stop(void)
> #define SVNSERVE_OPT_CACHE_REVPROPS 267
> #define SVNSERVE_OPT_SINGLE_CONN 268
>
> +/* Helper macros to stringify ra_svn's default port number. */
> +#define SVNSERVE_PORT(p) SVNSERVE_PORT_STR(p)
> +#define SVNSERVE_PORT_STR(p) #p
I'd suggest APR_STRINGIFY rather than new macros.
>...
Cheers,
-g