You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "malliaridis (via GitHub)" <gi...@apache.org> on 2024/11/04 17:40:18 UTC
Re: [PR] Prevent conflicting connection flags from being used via OptionGroup [solr]
malliaridis commented on PR #2725:
URL: https://github.com/apache/solr/pull/2725#issuecomment-2455326616
@epugh this one is ready I believe. The merge with main was ugly. >.<
I ended up with more lines added than removed, even though I have simplified and removed redundant elements. This is probably only because of the extraction of options to a separate file or variables.
I made a few cleanups and migrations for consistency and also fixed a bug in StatusTool (see 31b1becd357e3f6d22950e9868cd1ff07686b129). Now we are using `getOptionValue` only with `Option` as parameter, not strings. And I also migrated to `getParsedOptionValue` wherever possible (booleans are not supported and the File parsing seems buggy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org