[GitHub] [beam] Abacn commented on a diff in pull request #25247: Fix XVR_Direct time out

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #25247:
URL: https://github.com/apache/beam/pull/25247#discussion_r1093324810


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2534,9 +2534,13 @@ class BeamModulePlugin implements Plugin<Project> {
         dependsOn setupTask
         dependsOn config.startJobServer
       }
-      mainTask.configure{dependsOn goTask}
-      cleanupTask.configure{mustRunAfter goTask}
-      config.cleanupJobServer.configure{mustRunAfter goTask}
+      // CrossLanguageValidatesRunnerTask is setup under python sdk but also runs tasks not involving
+      // python versions. set 'skipNonPythonTask' property to avoid duplicated run of these tasks.
+      if (!(project.hasProperty('skipNonPythonTask') && project.skipNonPythonTask == 'true')) {
+        mainTask.configure { dependsOn goTask }
+      }
+      cleanupTask.configure { mustRunAfter goTask }
+      config.cleanupJobServer.configure { mustRunAfter goTask }

Review Comment:
   yes, besides a dependency to `validatesCrossLanguageRunner`, `validatesCrossLanguageRunnerGoUsingJava` task can be triggered alone,  where we are doing this for Dataflow XVR postcommits. Then clean up tassks should also be configured to run after it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org