[jira] [Commented] (SOLR-13264) unexpected autoscaling set-trigger response

["Christine Poerschke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775557#comment-16775557 ] 

Christine Poerschke commented on SOLR-13264:
--------------------------------------------

Attached revised patch which includes a {{IndexSizeTriggerTest.testValidProperties}} test. The test or the code change is currently incomplete i.e. it fails like this:
{code}
[junit4]    > Throwable #1: java.lang.AssertionError: Invalid _PROP constants: [__bytes__, __docs__, violationType, aboveSize, belowSize]
{code}

[~ab] - would you perhaps have any thoughts on this ticket?

> unexpected autoscaling set-trigger response
> -------------------------------------------
>
>                 Key: SOLR-13264
>                 URL: https://issues.apache.org/jira/browse/SOLR-13264
>             Project: Solr
>          Issue Type: Bug
>          Components: AutoScaling
>            Reporter: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-13264.patch, SOLR-13264.patch
>
>
> Steps to reproduce:
> {code}
> ./bin/solr start -cloud -noprompt
> ./bin/solr create -c demo -d _default -shards 1 -replicationFactor 1
> curl "http://localhost:8983/solr/admin/autoscaling" -d'
> {
>   "set-trigger" : {
>     "name" : "index_size_trigger",
>     "event" : "indexSize",
>     "aboveDocs" : 12345,
>     "aboveOp" : "SPLITSHARD",
>     "enabled" : true,
>     "actions" : [
>       {
>         "name" : "compute_plan",
>         "class": "solr.ComputePlanAction"
>       }
>     ]
>   }
> }
> '
> ./bin/solr stop -all
> {code}
> The {{aboveOp}} is documented on https://lucene.apache.org/solr/guide/7_6/solrcloud-autoscaling-triggers.html#index-size-trigger and logically should be accepted (even though it is actually the default) but unexpectedly an error message is returned {{"Error validating trigger config index_size_trigger: TriggerValidationException\{name=index_size_trigger, details='\{aboveOp=unknown property\}'\}"}}.
> From a quick look it seems that in the {{IndexSizeTrigger}} constructor additional values need to be passed to the {{TriggerUtils.validProperties}} method i.e. aboveOp, belowOp and maybe others too i.e. aboveSize/belowSize/etc. Illustrative patch to follow. Thank you.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org