You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/26 20:10:13 UTC

[GitHub] [thrift] cfriedt opened a new pull request, #2681: lib: cpp: TProtocol: support zephyr byteorder

cfriedt opened a new pull request, #2681:
URL: https://github.com/apache/thrift/pull/2681

   <!-- Explain the changes in the pull request below: -->
   Zephyr's byteorder is defined in `<zephyr/sys/byteorder.h>`. However, the `bswap_xx` macros are also defined there. They need to be `#undef`d first when building for big-endian architectures, since the Thrift byteorder macros are no-ops for little-endian architectures.
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   No
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   No
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   Yes
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] cfriedt commented on pull request #2681: lib: cpp: TProtocol: support zephyr byteorder

Posted by GitBox <gi...@apache.org>.
cfriedt commented on PR #2681:
URL: https://github.com/apache/thrift/pull/2681#issuecomment-1287836553

   rebased


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] cfriedt commented on pull request #2681: lib: cpp: TProtocol: support zephyr byteorder

Posted by GitBox <gi...@apache.org>.
cfriedt commented on PR #2681:
URL: https://github.com/apache/thrift/pull/2681#issuecomment-1290384207

   * rebased


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2681: THRIFT-5658: lib: cpp: TProtocol: support zephyr byteorder

Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2681:
URL: https://github.com/apache/thrift/pull/2681


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org