[GitHub] [kafka] ableegoldman commented on a change in pull request #11591: KAFKA-12648: fix IllegalStateException in ClientState after removing topologies

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #11591:
URL: https://github.com/apache/kafka/pull/11591#discussion_r766945306



##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/ClientStateTest.java
##########
@@ -406,12 +428,31 @@ public void shouldAddTasksInOffsetSumsMapToPrevStandbyTasks() {
             mkEntry(TASK_0_2, 100L)
         );
         client.addPreviousTasksAndOffsetSums("c1", taskOffsetSums);
-        client.initializePrevTasks(Collections.emptyMap());
+        client.initializePrevTasks(Collections.emptyMap(), false);
         assertThat(client.prevStandbyTasks(), equalTo(mkSet(TASK_0_1, TASK_0_2)));
         assertThat(client.previousAssignedTasks(), equalTo(mkSet(TASK_0_1, TASK_0_2)));
         assertTrue(client.prevActiveTasks().isEmpty());
     }
 
+    @Test
+    public void shouldThrowWhenSomeOwnedPartitionsAreNotRecognizedWhenInitializingPrevStandbyTasks() {

Review comment:
       Ah, whoops, yeah they used to differ but I had to take that line out -- I'll remove the duplicate tests




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org