[jira] [Commented] (HBASE-19770) Add '--return-values' option to Shell to print return values of commands in interactive mode

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-19770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327651#comment-16327651 ] 

Josh Elser commented on HBASE-19770:
------------------------------------

bq. we should make this change in branch-1, branch-2, and master at least. Maybe in 1.4.x too?

Fine for me too. Didn't spend any time thinking about where all it should land.

bq. The change is not enabling return-values by default when shell is started in non-interactive mode.

Ahh, good catch. I forgot to do that. Agree that it should only be relevant for interactive mode.


||Interactive||Return Values||
|True|False (default)|
|False|True (default)|


bq. nit: reverse the condition?

Sure :). I had this as {{unless return_values}} earlier and some of the ruby checkstyle things yelled at me. Didn't reverse it entirely :P

> Add '--return-values' option to Shell to print return values of commands in interactive mode
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-19770
>                 URL: https://issues.apache.org/jira/browse/HBASE-19770
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Romil Choksi
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0-beta-2
>
>         Attachments: HBASE-19770.001.branch-2.patch, HBASE-19770.002.branch-2.patch
>
>
> Another good find by our Romil.
> {code}
> hbase(main):001:0> list
> TABLE
> a
> 1 row(s)
> Took 0.8385 seconds
> hbase(main):002:0> tables=list
> TABLE
> a
> 1 row(s)
> Took 0.0267 seconds
> hbase(main):003:0> puts tables
> hbase(main):004:0> p tables
> nil
> {code}
> The {{list}} command should be returning {{\['a'\]}} but is not.
> The command class itself appears to be doing the right thing -- maybe the retval is getting lost somewhere else?
> FYI [~stack].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)