You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/21 15:15:54 UTC

[GitHub] [commons-lang] XenoAmess commented on a change in pull request #703: LANG-1641: GmtTimeZone now implements #equals(Object) using it's time…

XenoAmess commented on a change in pull request #703:
URL: https://github.com/apache/commons-lang/pull/703#discussion_r579821503



##########
File path: src/main/java/org/apache/commons/lang3/time/GmtTimeZone.java
##########
@@ -17,14 +17,16 @@
 package org.apache.commons.lang3.time;
 
 import java.util.Date;
+import java.util.Objects;
+import java.util.SimpleTimeZone;
 import java.util.TimeZone;
 
 /**
  * Custom time zone that contains offset from GMT.
  *
  * @since 3.7
  */
-class GmtTimeZone extends TimeZone {
+final class GmtTimeZone extends TimeZone {

Review comment:
       why make class GmtTimeZone final?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org