You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/11 14:37:41 UTC

[GitHub] [kafka] dengziming opened a new pull request #9734: KAFKA-10845; Add VisibleForTesting annotation

dengziming opened a new pull request #9734:
URL: https://github.com/apache/kafka/pull/9734


   *More detailed description of your change*
   
   There are a lot of comments like "visible for testing" "public for testing", for example: 
   https://github.com/apache/kafka/blob/ce275e29beb48611425708fbe67d28d17329845a/core/src/main/scala/kafka/controller/KafkaController.scala#L96
   so introduce a VisibleForTesting annotation.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #9734: KAFKA-10845; Add VisibleForTesting annotation

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #9734:
URL: https://github.com/apache/kafka/pull/9734#issuecomment-743979669


   Hi, @guozhangwang  PTAL.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming closed pull request #9734: KAFKA-10845; Add VisibleForTesting annotation

Posted by GitBox <gi...@apache.org>.
dengziming closed pull request #9734:
URL: https://github.com/apache/kafka/pull/9734


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org