You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "codelipenghui (via GitHub)" <gi...@apache.org> on 2023/03/07 03:37:49 UTC
[GitHub] [bookkeeper] codelipenghui opened a new pull request, #3842: Make read entry request recyclable
codelipenghui opened a new pull request, #3842:
URL: https://github.com/apache/bookkeeper/pull/3842
### Motivation
Make the read entry request object recyclable like the add request to reduce the object creation when doing catchup read from Pulsar.
### Changes
Add recycler to the read request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a diff in pull request #3842: Make read entry request recyclable
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #3842:
URL: https://github.com/apache/bookkeeper/pull/3842#discussion_r1127639601
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -122,6 +122,7 @@ protected void processPacket() {
if (LOG.isTraceEnabled()) {
LOG.trace("Read entry rc = {} for {}", errorCode, request);
}
+ request.recycle();
Review Comment:
sendResponse still using request. Maybe we should recycle at the ReadEntryProcessor#recycle()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codelipenghui commented on a diff in pull request #3842: Make read entry request recyclable
Posted by "codelipenghui (via GitHub)" <gi...@apache.org>.
codelipenghui commented on code in PR #3842:
URL: https://github.com/apache/bookkeeper/pull/3842#discussion_r1127866317
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -122,6 +122,7 @@ protected void processPacket() {
if (LOG.isTraceEnabled()) {
LOG.trace("Read entry rc = {} for {}", errorCode, request);
}
+ request.recycle();
Review Comment:
Yes, we can only recycle the request here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a diff in pull request #3842: Make read entry request recyclable
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #3842:
URL: https://github.com/apache/bookkeeper/pull/3842#discussion_r1127639601
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -122,6 +122,7 @@ protected void processPacket() {
if (LOG.isTraceEnabled()) {
LOG.trace("Read entry rc = {} for {}", errorCode, request);
}
+ request.recycle();
Review Comment:
sendResponse still uses request. Maybe we should recycle at the ReadEntryProcessor#recycle()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3842: Make read entry request recyclable
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3842:
URL: https://github.com/apache/bookkeeper/pull/3842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3842: Make read entry request recyclable
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3842:
URL: https://github.com/apache/bookkeeper/pull/3842#issuecomment-1457499993
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3842](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9715ea8) into [master](https://codecov.io/gh/apache/bookkeeper/commit/bf5a6aabb69d4898a261480a867b0a15416a6b88?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf5a6aa) will **decrease** coverage by `26.66%`.
> The diff coverage is `12.00%`.
```diff
@@ Coverage Diff @@
## master #3842 +/- ##
=============================================
- Coverage 47.40% 20.74% -26.66%
+ Complexity 4570 2011 -2559
=============================================
Files 473 473
Lines 40910 40931 +21
Branches 5232 5234 +2
=============================================
- Hits 19393 8491 -10902
- Misses 19532 31190 +11658
+ Partials 1985 1250 -735
```
| Flag | Coverage Δ | |
|---|---|---|
| remaining | `?` | |
| replication | `?` | |
| tls | `20.74% <12.00%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/bookkeeper/proto/BookieProtoEncoding.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vQm9va2llUHJvdG9FbmNvZGluZy5qYXZh) | `63.05% <0.00%> (-12.86%)` | :arrow_down: |
| [...va/org/apache/bookkeeper/proto/BookieProtocol.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vQm9va2llUHJvdG9jb2wuamF2YQ==) | `66.88% <0.00%> (-16.69%)` | :arrow_down: |
| [...rg/apache/bookkeeper/proto/ReadEntryProcessor.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUmVhZEVudHJ5UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (-49.52%)` | :arrow_down: |
| [...pache/bookkeeper/proto/PerChannelBookieClient.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vUGVyQ2hhbm5lbEJvb2tpZUNsaWVudC5qYXZh) | `52.05% <60.00%> (-15.90%)` | :arrow_down: |
| [.../java/org/apache/bookkeeper/util/SubTreeCache.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9TdWJUcmVlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rg/apache/bookkeeper/metastore/MetastoreTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/bookkeeper/meta/UnderreplicatedLedger.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9VbmRlcnJlcGxpY2F0ZWRMZWRnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/bookkeeper/server/conf/BookieConfiguration.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2NvbmYvQm9va2llQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../bookkeeper/metastore/MetastoreScannableTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVNjYW5uYWJsZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...bookkeeper/meta/LedgerUnderreplicationManager.java](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9MZWRnZXJVbmRlcnJlcGxpY2F0aW9uTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [266 more](https://codecov.io/gh/apache/bookkeeper/pull/3842?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org