[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #247: Fix unused properties related to implied choice sequences

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #247: Fix unused properties related to implied choice sequences
URL: https://github.com/apache/incubator-daffodil/pull/247#discussion_r297272063
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/SequenceGroup.scala
 ##########
 @@ -358,6 +358,8 @@ final class ChoiceBranchImpliedSequence(rawGM: Term)
   extends SequenceTermBase(rawGM.xml, rawGM.optLexicalParent, rawGM.position)
   with SequenceDefMixin {
 
+  override final lazy val groupMembers: Seq[Term] = LV('groupMembers) { Seq(rawGM) }.value
 
 Review comment:
   does not need to be an LV. It's just taking a constructor arg. No error SDE can happen here that we want blamed/positioned  to this object, nor can anything "circular" happen. Those are the two reasons to make something an LV. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services