You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/24 05:10:56 UTC

[GitHub] szha commented on a change in pull request #9539: Update test_gluon_model_zoo.py

szha commented on a change in pull request #9539: Update test_gluon_model_zoo.py
URL: https://github.com/apache/incubator-mxnet/pull/9539#discussion_r163454666
 
 

 ##########
 File path: tests/python/unittest/test_gluon_model_zoo.py
 ##########
 @@ -35,7 +35,7 @@ def test_models():
     pretrained_to_test = set(['squeezenet1.1'])
 
     for model_name in all_models:
-        test_pretrain = True #model_name in pretrained_to_test
+        test_pretrain = model_name in pretrained_to_test
 
 Review comment:
   I did want to enable more tests here, since it didn't take too long on my machine. The problem is that sometimes download could timeout and cause failure, so I'd like to revert it to keep minimum for now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services