You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by xu...@apache.org on 2023/04/03 13:27:12 UTC

[incubator-opendal] 01/01: chore: Cleanup code for oss writer

This is an automated email from the ASF dual-hosted git repository.

xuanwo pushed a commit to branch code-clean
in repository https://gitbox.apache.org/repos/asf/incubator-opendal.git

commit 4448fed091a51d5aae9f7e67724558b51cef47e8
Author: Xuanwo <gi...@xuanwo.io>
AuthorDate: Mon Apr 3 21:26:53 2023 +0800

    chore: Cleanup code for oss writer
    
    Signed-off-by: Xuanwo <gi...@xuanwo.io>
---
 core/src/services/oss/backend.rs |  4 ++--
 core/src/services/oss/writer.rs  | 13 ++++---------
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/core/src/services/oss/backend.rs b/core/src/services/oss/backend.rs
index d88f4e3a..dcd0a5b2 100644
--- a/core/src/services/oss/backend.rs
+++ b/core/src/services/oss/backend.rs
@@ -461,8 +461,6 @@ impl Accessor for OssBackend {
                     let result: InitiateMultipartUploadResult =
                         quick_xml::de::from_reader(bs.reader())
                             .map_err(new_xml_deserialize_error)?;
-                    let _ = result.bucket;
-                    let _ = result.key;
                     Some(result.upload_id)
                 }
                 _ => return Err(parse_error(resp).await?),
@@ -950,7 +948,9 @@ struct DeleteObjectsResultError {
 #[derive(Default, Debug, Deserialize)]
 #[serde(rename_all = "PascalCase")]
 struct InitiateMultipartUploadResult {
+    #[cfg(test)]
     bucket: String,
+    #[cfg(test)]
     key: String,
     upload_id: String,
 }
diff --git a/core/src/services/oss/writer.rs b/core/src/services/oss/writer.rs
index df012db2..ce7eb222 100644
--- a/core/src/services/oss/writer.rs
+++ b/core/src/services/oss/writer.rs
@@ -16,14 +16,14 @@
 // under the License.
 
 use async_trait::async_trait;
-use bytes::{Buf, Bytes};
+use bytes::Bytes;
 use http::StatusCode;
 
+use super::backend::MultipartUploadPart;
 use super::backend::OssBackend;
 use super::error::parse_error;
 use crate::ops::OpWrite;
 use crate::raw::*;
-use crate::services::oss::backend::{CompleteMultipartUploadResult, MultipartUploadPart};
 use crate::*;
 
 pub struct OssWriter {
@@ -128,13 +128,8 @@ impl oio::Write for OssWriter {
             .await?;
         match resp.status() {
             StatusCode::OK => {
-                let bs = resp.into_body().bytes().await?;
-                let result: CompleteMultipartUploadResult =
-                    quick_xml::de::from_reader(bs.reader()).map_err(new_xml_deserialize_error)?;
-                let _ = result.location;
-                let _ = result.key;
-                let _ = result.bucket;
-                let _ = result.etag;
+                resp.into_body().consume().await?;
+
                 Ok(())
             }
             _ => Err(parse_error(resp).await?),