You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/21 22:47:43 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7288: Adjust to actually try a server address more than once
shinrich opened a new pull request #7288:
URL: https://github.com/apache/trafficserver/pull/7288
Noticed this while testing connection retries across a server name with multiple addresses. I had the following settings
```
CONFIG proxy.config.http.connect_attempts_max_retries INT 6
CONFIG proxy.config.http.connect_attempts_rr_retries INT 3
```
And I had microdns set up to replay with addresses 192.168.1.10 and 192.168.1.13 for the name "foo".
I had a server listening on port 8888 on 192.168.1.10 but a iptables DROP rule on port 8888 for 192.168.1.13.
For my query that maps to maps to http://foo:8888, it was being sent to 192.168.1.13 first. In the original code, it would fail 192.168.1.13, mark it down, and then successfully connect to 192.168.1.10. So it ignored the connect_attempts_rr_retries count of 3.
With this code change, the same query would try and fail connections to 192.168.1.13 three times before marking it down and moving onto 192.168.1.10.
A note about the name "connect_attempts_rr_retries" implies this is the number of additional tries beyond the first try, but that is not how it is coded. And reviewing the documentation, that is not what is described either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7288: Adjust to actually try a server address more than once
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7288:
URL: https://github.com/apache/trafficserver/pull/7288#issuecomment-769453849
@rob05c Can you please take a look at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7288: Adjust to actually try a server address more than once
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7288:
URL: https://github.com/apache/trafficserver/pull/7288
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7288: Adjust to actually try a server address more than once
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7288:
URL: https://github.com/apache/trafficserver/pull/7288#issuecomment-772892506
Cherry-picked to v9.0.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7288: Adjust to actually try a server address more than once
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7288:
URL: https://github.com/apache/trafficserver/pull/7288#issuecomment-772902419
Cherry-picked to v9.1.x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org