You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/05/31 16:09:10 UTC
[GitHub] [netbeans] sdedic opened a new pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
sdedic opened a new pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984
Completion items that were taken from indexes or java classes had either no `ElementHandle` or some simple one, which did not allow to resolve them back. I added a Handle subclass that records java support's ElementHandle or at least FQNs more or less suficient to find an `ElementHandle` later (for creations not backed by Element from the java support).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a change in pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
Posted by GitBox <gi...@apache.org>.
sdedic commented on a change in pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984#discussion_r643027843
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
##########
@@ -910,30 +955,18 @@ public boolean equals(Object obj) {
}
}
- public static class JavaFieldItem extends CompletionItem {
-
- private final String className;
- private final String name;
+ public static class JavaFieldItem extends JavaElementItem {
Review comment:
@JaroslavTulach I'll better rework the change - it'd prefer not to introduce any API changes at all :-/ Those APIs are too open already. Sorry for the inconvenience - you'll be reviewing once more ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984#discussion_r642927967
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionHandler.java
##########
@@ -53,12 +61,14 @@
import org.netbeans.modules.groovy.editor.api.lexer.LexUtilities;
import org.netbeans.modules.groovy.editor.utils.GroovyUtils;
import org.netbeans.modules.groovy.editor.api.completion.util.CompletionContext;
+import org.netbeans.modules.groovy.editor.java.JavaElementHandle;
import org.netbeans.modules.groovy.support.api.GroovySettings;
+import org.openide.util.Exceptions;
import org.openide.util.NbBundle;
import org.openide.util.Utilities;
import org.openide.util.WeakListeners;
-public class CompletionHandler implements CodeCompletionHandler {
+public class CompletionHandler implements CodeCompletionHandler2 {
Review comment:
`CodeCompletionHandler2` has been introduced in version of 2.43 of the csl.api. Please update dependency from 2.21 to 2.43.
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/api/completion/CompletionItem.java
##########
@@ -910,30 +955,18 @@ public boolean equals(Object obj) {
}
}
- public static class JavaFieldItem extends CompletionItem {
-
- private final String className;
- private final String name;
+ public static class JavaFieldItem extends JavaElementItem {
Review comment:
API change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984#issuecomment-852166784
Redone. Hopefully no API changes should be visible now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #2984: Completion items imported from Java delegate to ElementJavadoc to get the content.
Posted by GitBox <gi...@apache.org>.
sdedic merged pull request #2984:
URL: https://github.com/apache/netbeans/pull/2984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists