You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dnskr (via GitHub)" <gi...@apache.org> on 2025/06/10 20:19:02 UTC

[PR] style(helm): Minor reformatting of helm chart templates [superset]

dnskr opened a new pull request, #33736:
URL: https://github.com/apache/superset/pull/33736

   ### SUMMARY
   The PR reformats few chart templates to follow common indents style.
   The PR does not change any functionality of the chart.
   
   ### TESTING INSTRUCTIONS
   The following command install the chart
   ```shell
   helm install superset helm/superset
   ```
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] style(helm): Minor reformatting of helm chart templates [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #33736:
URL: https://github.com/apache/superset/pull/33736#issuecomment-3084056644

   Looks like a plain improvement, thank you for submitting this and sorry it lingered. I'm not a helm chart code owner so I can't approve + merge, otherwise I would - let me see if I can get someone to.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] style(helm): Minor reformatting of helm chart templates [superset]

Posted by "nytai (via GitHub)" <gi...@apache.org>.
nytai merged PR #33736:
URL: https://github.com/apache/superset/pull/33736


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] style(helm): Minor reformatting of helm chart templates [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33736:
URL: https://github.com/apache/superset/pull/33736#issuecomment-2968330485

   Tagging @villebro as he's been closer to this helm chart


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org